contrib/google.golang.org/grpc: Reduce allocs in interceptor #1183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finishWithError needs to allocate a []tracer.FinishOption slice to
pass arguments to span.Finish. However, those arguments are only used
if err != nil. Only allocate the slice if it is used. Allocate the
exactly right size of slice. This appears to remove 3 allocations in
the "no error" case, and 1 allocation if the NoDebugStack() option is
specified. In the case of an error, there is no difference. This may
also make a small difference in the run time. The benchstat results
from my Mac laptop are below.